Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues in big-endian platforms #39

Merged
merged 7 commits into from
Aug 27, 2023
Merged

fix: issues in big-endian platforms #39

merged 7 commits into from
Aug 27, 2023

Conversation

plusvic
Copy link
Member

@plusvic plusvic commented Aug 27, 2023

Stop using the memx crate which doesn't compile in big-endian platforms and fix an bug while reading i32 integers from WASM memory.

The `memx` doesn't compile correctly in big-endian platforms. For the time being let's use the `==` operator for slice comparison. This change may be reconsidered later if the `==` operators proves to be too slow.
When reading `i32` integers from WASM memory the integers must be swapped if we are in big-endian platforms because WASM stores the integers in little-endian format regardless of the host's endianness.
@plusvic plusvic enabled auto-merge (rebase) August 27, 2023 16:48
The debug build depends on `yara` for benchmarks, but this crate is not built correctly in the s390x platform.
When a commit is pushed to an open pull request the workflow will run twice: once for the push and once for the pull request, unless we specified that workflow for pull requests should run only when the pull request is opened or reopened.
@plusvic plusvic merged commit f084935 into main Aug 27, 2023
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant